Re: [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicatedworkqueue

[Todd Fischer]

Hi Dan,

Polling is only necessary because I was given brain dead hardware.  I 
was expecting updated hardware with the interrupt signal connected 
properly, but haven't received it yet.

Any reasonable hardware will not need tps6507x-ts polling.  I was under 
the impression I could only push patches that I have tested.  Since I 
haven't tested an interrupt version of the driver, I didn't include a 
patch that removes the polling and replaces it with interrupts.

I have another customer planning on using the TPS6507x chip for touch 
screen.  I expect their hardware in around 3 weeks.

Todd

On 01/03/2011 07:39 AM, Dan Carpenter wrote:
> On Mon, Jan 03, 2011 at 02:49:33PM +0100, Tejun Heo wrote:
> > With cmwq, there's no reason to use a separate workqueue.  Drop
> > tps6507x_ts->wq and use system_wq instead.
> >
> > Signed-off-by: Tejun Heo<tj@xxxxxxxxxx>
> > Cc: Dmitry Torokhov<dmitry.torokhov@xxxxxxxxx>
> > Cc: linux-input@xxxxxxxxxxxxxxx
> > Cc: Dan Carpenter<error27@xxxxxxxxx>
> > Cc: Todd Fischer<todd.fischer@xxxxxxxxxxxx>
> > ---
> > Only compile tested.  Please feel free to take it into the subsystem
> > tree or simply ack - I'll route it through the wq tree.
> This is that driver that polls every 30 ms.  :/  Todd, is there no way
> to avoid this?  What was the status on that?
>
> regards,
> dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/