Re: [PATCH 2/3] mx3_camera: Support correctly the YUV222 and BAYERconfigurations of CSI

From: Guennadi Liakhovetski
Date: Mon Jan 03 2011 - 11:24:13 EST


On Mon, 3 Jan 2011, Alberto Panizzo wrote:

[snip]

> Guennadi, how do you consider the path I've shown? Can I continue in this
> way or shall I present a patch that get rid of translations and manage
> all the pixel format in the way I understood the manual speak about?
>
> I prefer this way that maintain the usability of the whole set of pixel codes
> for everyone after this step and then fix together the translations.
> I don't hold a camera that output a grey format..

Sorry, I'm not sure I understand what exactly you're proposing. Please,
just look at my last reply, in which I explain, why I don't think this is
a good way to fix things. You don't need to support various formats
natively on CSI / IPU to be able to just pass data 1-to-1. If that is your
only purpose, please, test it that way, and if it is broken, please, fix
it. This would be good even if you actually want to support formats
natively eventually, because that would also fix other formats with
similar sample-per-pixel values. When this is fixed, if you want to
actually support formats natively to perform some hardware-assisted format
conversions, that also can be done, but then, please, explain this clearly
in your patch (series).

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/