Re: [PATCH 24/32] dlm: dlm workqueues aren't used in memoryreclaim path

[Tejun Heo]

Hello again,

On Mon, Jan 03, 2011 at 02:21:29PM +0000, Steven Whitehouse wrote:
> > Ooh, I see.  Hmmm... maybe I've asked this before but do you really
> > need WQ_MEM_RECLAIM there?  Is dlm used during memory reclaim?
> 
> Yes, it is in case of deallocation of inodes, so we have to be careful
> about that,

I see.  I'm still slightly unsure about the WQ_MEM_RECLAIM rules when
it comes to distributed file systems and stuff related to them, but I
think it basically comes down to whether the code can be in the swap
path or not.  e.g. for nfs backed write shared mapped files, nfs
definitely can be used during memory reclaim _but_ it's not guaranteed
to make forward progress under memory pressure and thus can't be
depended upon and shouldn't be used for swap.  IOW, it may free memory
but it's not in the critical path which should guarantee forward
progress.  Isn't dlm the same case?

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/