Re: [PATCH] [SCSI] arcmsr: &/| confusion in arcmsr_build_ccb()

From: Matthew Wilcox
Date: Sat Jan 01 2011 - 18:34:28 EST


On Sat, Jan 01, 2011 at 06:28:34PM +0100, Torsten Kaiser wrote:
> <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ae52e7f09ff509df11cd408eabe90132b6be1231;hp=f034260db330bb3ffc815fcb682b1c84aca09591#patch2>
> - if (pcmd->sc_data_direction == DMA_TO_DEVICE ) {
> + if (pcmd->cmnd[0]|WRITE_6 || pcmd->cmnd[0] | WRITE_10 ||
> pcmd->cmnd[0]|WRITE_12) {
>
> Until June 2010 it was that way...

So it was. Nick, why did you make this change? Your commit message is
less than informative, partly because you're making such huge changes
in a single commit.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/