Re: [PATCH] Show version information for built-in modules in sysfs

[Dmitry Torokhov]

On Wed, Dec 15, 2010 at 03:25:27PM -0800, Alexey Dobriyan wrote:
> On Thu, Dec 16, 2010 at 12:14 AM, Dmitry Torokhov <dtor@xxxxxxxxxx> wrote:
> > On Wed, Dec 15, 2010 at 02:06:03PM -0800, Alexey Dobriyan wrote:
> >> On Thu, Dec 16, 2010 at 12:00 AM, Dmitry Torokhov <dtor@xxxxxxxxxx> wrote:
> >> > Currently only drivers that are built as modules have their versions
> >> > shown in /sys/module/<module_name>/version, but this information might
> >>
> >> Can you create just /sys/module/x?
> >> Module version info is quite useless by itself.
> >
> > It is as useful as in the case where driver is built as a module. I am
> > just trying to unify the behavior a bit.
> >
> > Code-wise it is almost as cheap to add /sys/module/x/version as adding
> > just the directory.
> 
> OK.
> 
> Still, people are using /sys/module/x presence as indicator of modular
> built (unsurprisingly).
> 
> http://codesearch.google.com/codesearch/p?hl=en#wZuuyuB8jKQ/src/third_party/autotest/files/client/profilers/powertop/src/bluetooth.c&q=/sys/modules&sa=N&cd=3&ct=rc&l=105

Yeah, I hate to disappoint them but it will break as soon as someone
adds a module_param() to one of the objects... That's even without my
changes.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/