Re: [Patch 5/21] Rename compat versions of the reusable coregeneration routines

[Suzuki K. Poulose]

On Tue, 14 Dec 2010 16:57:08 +0100
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> On 12/14, Suzuki K. Poulose wrote:
> >
> > Rename the ELF class specific functions reusable for the application core dump 
> > infrastructure. The compat ELF class routines are prepended with compat_ .
> >
> > Signed-off-by: Suzuki K. Poulose <suzuki@xxxxxxxxxx>
> > ---
> >  fs/compat_binfmt_elf.c |    7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > Index: linux-2.6.36-rc7/fs/compat_binfmt_elf.c
> > ===================================================================
> > --- linux-2.6.36-rc7.orig/fs/compat_binfmt_elf.c
> > +++ linux-2.6.36-rc7/fs/compat_binfmt_elf.c
> > @@ -127,6 +127,13 @@ static void cputime_to_compat_timeval(co
> >  #define init_elf_binfmt		init_compat_elf_binfmt
> >  #define exit_elf_binfmt		exit_compat_elf_binfmt
> >
> > +/* Rename the functions that may be reused */
> > +#define fill_elf_header 	compat_fill_elf_header
> > +#define fill_psinfo		compat_fill_psinfo
> > +#define fill_prstatus		compat_fill_prstatus
> > +#define fill_extnum_info	compat_fill_extnum_info
> > +#define fill_auxv_note		compat_fill_auxv_note
> 
> Can't undestand.... Afaics, the kernel can't be compiled
> with this change until the next patches actually implement
> compat_xxx ?

The compat_binfmt_elf.c shares the actual ELF handling code from binfmt_elf.c (by 
#includ ing it). This patch renames the functions so that we can later export it. 
The "#include binfmt_elf.c" comes later in the compat_binfmt_elf.c. So we are fine.
> 
> This is not bisect friendly.
> 
> Oleg.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/