Re: [RESEND] [PATCH] kernel/panic.c: Fix two checkpatch.pl errors(whitespace cleanup)

From: Dan Carpenter
Date: Tue Dec 14 2010 - 13:43:20 EST


On Tue, Dec 14, 2010 at 05:58:08PM +0100, Toralf Förster wrote:
> nothing else
>

This patch is not helpful. I mean that in the sense that the code is
just as readable before and after. :/ Please only send patches that
make the code better.

Checkpatch.pl is a good tool for staging but outside of staging you
should only use it for [check]ing [patch]es. The problem is that
pointless churn clutters up the log and breaks git blame. In staging
that's Ok.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/