Re: [Patch 16/21] Wait for threads to freeze

From: Oleg Nesterov
Date: Tue Dec 14 2010 - 11:49:22 EST


On 12/14, Suzuki K. Poulose wrote:
>
> + * zero_thread_state :
> + * For threads, which are not frozen, we cannot capture the register state.

Indeed, but

> + if (!tinfo->frozen)
> + zero_thread_state(tinfo);

Again, we can race with TASK_STOPPED/SIGCONT. And
is_task_frozen_enough() thins task_is_stopped_or_traced() is fine.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/