[PATCH net-next-2.6] bnx2: remove cancel_work_sync() from remove_one

From: Tejun Heo
Date: Tue Dec 14 2010 - 11:10:11 EST


Michael pointed out that bnx2_close() already cancels bp->reset_task
and thus it is guaranteed to be idle when bnx2_remove_one() is called.
Remove the unnecessary cancel_work_sync() in remove_one.

Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
Cc: Michael Chan <mchan@xxxxxxxxxxxx>
---
drivers/net/bnx2.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 5c811f3..85fc2c8 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -8393,8 +8393,6 @@ bnx2_remove_one(struct pci_dev *pdev)
struct net_device *dev = pci_get_drvdata(pdev);
struct bnx2 *bp = netdev_priv(dev);

- cancel_work_sync(&bp->reset_task);
-
unregister_netdev(dev);

if (bp->mips_firmware)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/