Re: [Patch 4/21] Make fill_psinfo generic

From: Linus Torvalds
Date: Tue Dec 14 2010 - 10:55:56 EST


On Tue, Dec 14, 2010 at 2:01 AM, Suzuki K. Poulose <suzuki@xxxxxxxxxx> wrote:
> +       /*
> +        * If we are dumping core for "another task"
> +        * we can't use copy_from_user().
> +        */
> +       if (p->group_leader == current->group_leader) {

This is totally bogus. "group_leader" has absolutely nothing to do
with whether the process shares the address space. It's about signal
sharing etc.

The way to check whether they share the same address space is to check
whether "mm" is the same.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/