Re: [RFC] intel_mid: Intel MSIC battery driver

[Mark Brown]

On Tue, Dec 14, 2010 at 01:51:56PM +0530, Pallala, Ramakrishna wrote:

> > > +       if (mbi->ch_params.vinilmt == CHRG_CURR_SDP_LOW)
> > > +               mbi->usb_chrg_props.charger_type =
> > POWER_SUPPLY_CHARGE_TYPE_TRICKLE;
> > > +       else
> > > +               mbi->usb_chrg_props.charger_type =
> > > +                                       POWER_SUPPLY_CHARGE_TYPE_FAST;

> > This isn't what fast and trickle charge are, they're not static
> > properties but rather reflect the kind of charging that's being done.

> If I understand correctly trickle charging will happen during full(or
> deeply discharge) charge conditions.  But as soon as I hit the charge
> full condition I am stopping the charging and will go into maintenance
> mode.  In maintenance mode I will check battery voltage to hit for
> lower threshold value and then enable the charging.  During
> maintenance mode battery voltage is near to FULL charge value, So can I
> set the charging type to trickle during maintenance  mode?

Given that it looks like this battery is capable of reporting more
detailed information such as the current that's being used to charge at
the moment I'm not sure it's worth supporting this property at all.  The
property exists because with the chargers used in many small embedded
devices use this something the hardware reports directly and you don't
get much more information than that.  If (as it seems) your charger has
no directly exported concept of different charge types then it's
probably safer to just not report this property and let userspace worry
about it.

The normal use for this information is figuring out why the battery is
taking longer than expected to charge - if the charger is stuck in
trickle charge then charging will take a very long time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/