Re: [PATCH] aio: check return value of create_workqueue()

From: Jeff Moyer
Date: Mon Dec 13 2010 - 10:58:23 EST


Namhyung Kim <namhyung@xxxxxxxxx> writes:

> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx>
> ---
> fs/aio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 8c8f6c5b6d79..c56153f5f73e 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -87,7 +87,7 @@ static int __init aio_setup(void)
>
> aio_wq = create_workqueue("aio");
> abe_pool = mempool_create_kmalloc_pool(1, sizeof(struct aio_batch_entry));
> - BUG_ON(!abe_pool);
> + BUG_ON(!aio_wq || !abe_pool);
>
> pr_debug("aio_setup: sizeof(struct page) = %d\n", (int)sizeof(struct page));

Acked-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/