Re: [PATCH 2/9] drivers/net: don't use flush_scheduled_work()

[Lennert Buytenhek]

On Sun, Dec 12, 2010 at 04:52:58PM +0100, Tejun Heo wrote:

> flush_scheduled_work() is on its way out.  This patch contains simple
> conversions to replace flush_scheduled_work() usage with direct
> cancels and flushes.
> 
> Directly cancel the used works on driver detach and flush them in
> other cases.
> 
> The conversions are mostly straight forward and the only dangers are,
> 
> * Forgetting to cancel/flush one or more used works.
> 
> * Cancelling when a work should be flushed (ie. the work must be
>   executed once scheduled whether the driver is detaching or not).
> 
> I've gone over the changes multiple times but it would be much
> appreciated if you can review with the above points in mind.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Jay Cliburn <jcliburn@xxxxxxxxx>
> Cc: Michael Chan <mchan@xxxxxxxxxxxx>
> Cc: Divy Le Ray <divy@xxxxxxxxxxx>
> Cc: e1000-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: Vasanthy Kolluri <vkolluri@xxxxxxxxx>
> Cc: Samuel Ortiz <samuel@xxxxxxxxxx>
> Cc: Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>
> Cc: Andrew Gallatin <gallatin@xxxxxxxx>
> Cc: Francois Romieu <romieu@xxxxxxxxxxxxx>
> Cc: Ramkrishna Vepa <ramkrishna.vepa@xxxxxxxx>
> Cc: Matt Carlson <mcarlson@xxxxxxxxxxxx>
> Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Shreyas Bhatewara <sbhatewara@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx

For the mv643xx_eth part:

Acked-by: Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/