[PATCH] [185/223] Staging: udlfb: fix up some sysfs attribute permissions

From: Andi Kleen
Date: Sun Dec 12 2010 - 18:55:59 EST


2.6.35-longterm review patch. If anyone has any objections, please let me know.

------------------
From: Greg Kroah-Hartman <gregkh@xxxxxxx>

commit cc9ca9dfddda46b1802d325891a69d7efdbe1f1e and
cc9ca9dfddda46b1802d325891a69d7efdbe1f1e upstream merged together.

They should not be writable by any user

Reported-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Bernie Thompson <bernie@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

---
drivers/staging/udlfb/udlfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/staging/udlfb/udlfb.c
===================================================================
--- linux.orig/drivers/staging/udlfb/udlfb.c
+++ linux/drivers/staging/udlfb/udlfb.c
@@ -1143,7 +1143,7 @@ static struct device_attribute fb_device
__ATTR_RO(metrics_bytes_sent),
__ATTR_RO(metrics_cpu_kcycles_used),
__ATTR_RO(metrics_misc),
- __ATTR(metrics_reset, S_IWUGO, NULL, metrics_reset_store),
+ __ATTR(metrics_reset, S_IWUSR, NULL, metrics_reset_store),
__ATTR_RW(use_defio),
};

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/