Re: [PATCH] pci: Skip id checking if no id is passed

[Jesse Barnes]

On Wed, 17 Nov 2010 12:10:40 -0800
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> 
> Will get warning when pci stub driver is built-in kenel like:
> pci-stub: invalid id string ""
> 
> So stop early if no id is passed.
> 
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> 
> ---
>  drivers/pci/pci-stub.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> Index: linux-2.6/drivers/pci/pci-stub.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pci-stub.c
> +++ linux-2.6/drivers/pci/pci-stub.c
> @@ -47,6 +47,10 @@ static int __init pci_stub_init(void)
>  	if (rc)
>  		return rc;
>  
> +	/* no ids passed actually */
> +	if (ids[0] == '\0')
> +		return 0;
> +
>  	/* add ids specified in the module parameter */
>  	p = ids;
>  	while ((id = strsep(&p, ","))) {
> 

Applied to linux-next, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/