Re: [PATCH 1/8] staging: ft1000: Convert char device to debugfs.

[Greg KH]

On Fri, Dec 10, 2010 at 12:35:33PM -0500, Dave Jones wrote:
> On Thu, Dec 09, 2010 at 01:43:36PM +0300, Dan Carpenter wrote:
>  > > +	file = debugfs_create_file("device", S_IRUGO | S_IWUGO, dir,
>  >                                                        ^^^^^^^
>  > > +					NULL, &ft1000fops);
>  > 
>  > Don't make this world writeable.
> 
> we should probably make checkpatch catch this.
> 
> 
> 
> 
> Exporting world writable sysfs/debugfs files is usually a bad thing.
> Warn about it.
> 
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/