Re: [PATCH] mfd/wm831x-irq: Convert to new irq_chip functions andfix build failure

From: Mark Brown
Date: Fri Dec 10 2010 - 12:32:55 EST


On Sat, Dec 11, 2010 at 02:01:31AM +0900, Paul Mundt wrote:

> The above 4 at least should have their dependencies tidied up. The rest
> of them will break on an allmod/yesconfig for SH for .37, which the
> following patch addresses. On the other hand, none of these are really
> all that pressing, particularly as none of these are used by any of the
> SH defconfigs.

> I had considered adding a GENERIC_HARDIRQS_DEPRECATED, but that
> unfortunately gets to be a bit tricky since almost no one sources
> kernel/irq/Kconfig yet, and this isn't likely to be a problem for very
> long anyways -- it's basically just the MFD drivers that play around with
> the irq_chip anyways.

Please remove the changes for the Wolfson drivers, as I said in my
previous mails if you insist that this must be changed in 2.6.37 I would
much rather cherry-pick the existing changes over into 2.6.37 than have
them unusuable on SH for a release (and we'd need to fix -next to remove
the dependency anyway).

If you're checking this stuff it'd be good to also take a look at
drivers/gpio - there's a bunch of irq_chips in there too. I would also
urge you to also contact the maintainers for the relevant drivers while
doing these checks, I suspect quite a few people aren't aware of the new
APIs yet.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/