Re: [patch]block cfq: select new workload if priority changed

From: Jeff Moyer
Date: Fri Dec 10 2010 - 09:56:26 EST


Shaohua Li <shaohua.li@xxxxxxxxx> writes:

> If priority is changed, continue checking workload_expires and service tree
> count of previous workload is meaningless. We should always choose the workload

I'd change that first sentence to:

If priority is changed, continuing to check workload_expires and
service tree count of the previous workload does not make sense.

> with lowest key of new priority in such case.
>
> Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>

This makes sense to me.

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/