Re: [PATCH] Update MCP55 quirk to not affect non HyperTransportvariants

[Neil Horman]

On Thu, Dec 09, 2010 at 03:40:41PM -0800, Andrew Morton wrote:
> On Wed,  8 Dec 2010 09:47:48 -0500
> Neil Horman <nhorman@xxxxxxxxxxxxx> wrote:
> 
> > I wrote this quirk awhile ago to properly setup MCP55 chips on hypertransport
> > busses so that interrupts reached whatever cpu happend to boot the kdump kernel.
> > while that works well, it was recently shown to me that a a non-hypertransport
> > variant of the MCP55 exists, and on those system the register that this quirk
> > manipulates causes hangs if you write to it.  Since the quirk was only meant to
> > handle errors found on MCP55 chips that have a HT interface, this patch adds a
> > filter to make sure the chip is an HT capable before making the needed register
> > adjustment.  This lets the broken MCP55s work with kdump while not breaking the
> > non-HT variants.
> > 
> > Resolves https://bugzilla.kernel.org/show_bug.cgi?id=23952
> > 
> > Tested successfully by the reporter and myself.
> > 
> > Reported-by: Mathieu B__rard <mathieu@xxxxxxxxxx>
> > CC: linux-pci@xxxxxxxxxxxxxxx
> > CC: kexec@xxxxxxxxxxxxxxxxxxx
> > CC: Vivek Goyal <vgoyal@xxxxxxxxxx>
> > CC: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
> 
> That needed a Cc:<stable@xxxxxxxxxx> as well.  Please don't forget to
> remember -stable.
Thanks, Cc'ing stable on the thread

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/