Re: [RFC][PATCH 02/10] mm: Remove likely() from mapping_unevictable()

[Miles Bader]

Joe Perches <joe@xxxxxxxxxxx> writes:
> It'd be better to use
>
> 	if (!mapping)
> 		return 0;
> 	return test_bit(AS_UNEVICTABLE, &mapping->flags);
>
> to avoid the unnecessary !!

How about 

 	return mapping && test_bit(AS_UNEVICTABLE, &mapping->flags);

instead...?

-miles

-- 
Yossarian was moved very deeply by the absolute simplicity of
this clause of Catch-22 and let out a respectful whistle.
"That's some catch, that Catch-22," he observed.
"It's the best there is," Doc Daneeka agreed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/