Re: [PATCH] hid: Add and use hid_<level>: dev_<level> equivalents

[Jiri Kosina]

On Tue, 23 Nov 2010, Joe Perches wrote:

> Neaten current uses of dev_<level> by adding and using
> hid specific hid_<level> macros.
> 
> Convert existing uses of dev_<level> uses to hid_<level>.
> Convert hid-pidff printk to use hid_<level>.
> 
> Remove err_hid and use hid_err instead.
> 
> Add missing newlines to logging messages where necessary.
> Coalesce format strings.
> 
> Add and use pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> Other miscellaneous changes:
> 
> Convert vmalloc/memset to vzalloc
> Remove unnecessary __inline_ from some static functions.
> Add const struct hid_device * as argument to some functions
> so hid_<level> can be used as appropriate.
> Remove unnecessary multiplies in inner loops, use += instead.

Hi Joe,

even though these are purely cleanup changes, I'd like to have them 
separated (or at least have more appropriate Subject: line for the 
commit).

Would you care to split that up?

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/