Re: Aw: Re: [PATCH 0/5] HID: roccat: Achieve userspace notificationon sysfs attribute creation

[Jiri Kosina]

On Thu, 9 Dec 2010, Stefan Achatz wrote:

> > I have applied the series, and removed the #pragma pack ugliness. Thanks,
> 

> Hello Jiri,
> Using my patch replacing the #pragma pack with the __packed macro would 
> have saved you some time: https://lkml.org/lkml/2010/11/27/14

Ah, missed that. Never mind.

> Just for the future: Whats better using the verbose version 
> __attribute__ ((__packed__)) or the macro __packed as I did?

I don't think I really care deeply here.

For some rationale why these shortcuts exist, please see commit 
82ddcb0405704.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/