Re: [PATCH v5 resend] OLPC: Add XO-1 suspend/resume support

[Daniel Drake]

On 8 December 2010 22:50, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> x86_64 allmodconfig gives me
>
> {standard input}: Assembler messages:
> {standard input}:300: Error: suffix or operands invalid for `mov'

Thanks, will check. this indeed won't work on x86_64, need to get it
excluded there.

> Also, this checkpatch warning
>
> WARNING: struct platform_suspend_ops should normally be const
> #502: FILE: arch/x86/platform/olpc/xo1.c:106:
> +static struct platform_suspend_ops xo1_suspend_ops = {
>
> seems valid.

When you correct it (to make it const), gcc gives a warning, because
suspend_set_ops() takes non-const arg. I was thinking that casting
const to non-const would be worse than checkpatch warning.

Also working on the extensive feedback from Thomas, next version will
be cleaner and clearer.

Thanks!
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/