Re: [PATCH] staging: tidspbridge: remove file handling functionsfor loader

From: Greg KH
Date: Wed Dec 08 2010 - 17:37:57 EST


On Tue, Dec 07, 2010 at 12:09:06AM -0600, Omar Ramirez Luna wrote:
> Instead use request_firmware and friends to get a valid firmware
> image.
>
> Right now the image is supplied dynamically through udev and the
> following rule:
>
> KERNEL=="omap-dsp", SUBSYSTEM=="firmware", ACTION=="add", \
> RUN+="/bin/sh -c 'echo 1 > /sys/$DEVPATH/loading; \
> cat $FIRMWARE > /sys/$DEVPATH/data; \
> echo 0 > /sys/$DEVPATH/loading'"

Why do you need a custom firmware rule? Why doesn't the default
firmware loading rule that comes with udev work properly for you? What
are you needing different here that works properly for all other
drivers?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/