Re: [PATCH] input: mt: Add hovering distance axis

From: Henrik Rydberg
Date: Wed Dec 08 2010 - 13:16:36 EST


On 12/08/2010 07:05 PM, Dmitry Torokhov wrote:

> On Wed, Dec 08, 2010 at 09:46:04AM -0800, Chase Douglas wrote:
>> On 12/07/2010 12:27 AM, Henrik Rydberg wrote:
>>> Touch devices capable of hovering, i.e., fingers detected a distance
>>> from the surface, are not supported by the current input MT
>>> protocol. This patch adds ABS_MT_DISTANCE, which may be used to
>>> indicate the distance between the contact and the surface.
>>
>> Have you given thought to calling it ABS_MT_Z instead? I have no real
>> problem with ABS_MT_DISTANCE per se, but ABS_MT_Z is more clearly
>> defined in my head. If I was new to MT development I may wonder if
>> ABS_MT_DISTANCE had anything to do with distance between points or some
>> other object.
>
> X/Y/Z imply that we fully engaged the device and it is 3 dimensional.
> Distance says that we are approaching the device but have not directly
> engaged it yet.


Yep, and we will surely start seeing more 3D devices soon, so reserving _Z for
those is a given.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/