Re: [PATCH] syslog: check cap_syslog when dmesg_restrict

[Eric Paris]

On Wed, 2010-12-08 at 16:42 +0000, Serge E. Hallyn wrote:
> Quoting Eric Paris (eparis@xxxxxxxxxx):

> >   I think the code might be
> > incorrect today as well......
> > 
> > I thought the flow was supposed to be
> > 
> > if (capable(CAP_SYSLOG))
> > 	all good
> > else if (capable(CAP_SYS_ADMIN))
> > 	WARN, but still good for now
> 
> I prefer warn and deny.  Otherwise it's too easy to ignore warnings.  So
> I prefer the msg to be there to explain why it failed - not that I expect
> it to fail for anyone today.

Ok, fine with me.

Acked-by: Eric Paris <eparis@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/