Re: [RFC] bind/unbind uevent

From: Greg KH
Date: Wed Dec 08 2010 - 11:03:25 EST


On Wed, Dec 08, 2010 at 11:18:27AM +0100, Sebastian Ott wrote:
> On Tue, 7 Dec 2010, Kay Sievers wrote:
> > On Tue, Dec 7, 2010 at 19:33, Greg KH <gregkh@xxxxxxx> wrote:
> > > On Tue, Dec 07, 2010 at 06:29:37PM +0100, Sebastian Ott wrote:
> >
> > >> So I'm searching for a trigger when these attributes are created, or
> > >> in other words when the device is useable, which I think translates to
> > >> when a driver is bound to this device.
> > >
> > > Again, KOBJ_ADD is the correct one.
> > >
> > > If your driver is creating sysfs attributes on its own, that's a bug and
> > > should be fixed.
> >
> > Sounds a bit like the driver should create its own child device with
> > its own properties, instead of mangling around with attributes at a
> > device it binds to.
>
> Yes, I get that feeling too. But I'm talking about existing drivers
> and I don't think I can change their whole structure.

It's just a matter of putting the attributes in a table and passing that
to the bus code the driver registers with. Only a minor change in the
driver is needed to resolve this.

good luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/