Re: visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

[Geert Uytterhoeven]

On Tue, Dec 7, 2010 at 21:40, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
> On Tue, Dec 7, 2010 at 3:31 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>> On Tue, Dec 7, 2010 at 20:51, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
>>> On Tue, Dec 7, 2010 at 2:07 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>>>> On Sat, Dec 4, 2010 at 14:57, Michal Marek <mmarek@xxxxxxx> wrote:
>>>>> please pull these kbuild/kconfig fixes for the next -rc. The largest
>>>>> part are fixes for the annoying kconfig warnings, contributed by Arnaud
>>>>> Lacombe and Mauro Carvalho Chehab. The solution adds a new 'visible if'
>>>>> keyword to the Kconfig language, so it's not exactly something that one
>>>>> would expect in the rc phase, but the kconfig change is not huge (the
>>>>> large diff is due to generated files) and it is deployed only in those
>>>>> five Kconfig files that had the warnings and were hard to fix by other
>>>>> means. ÂThe second part is a forgotten patch by Hendrik Brueckner to
>>>>> usr/initramfs, that fixes build for Blackfin and h8300.
>>>>
>>>>> Arnaud Lacombe (5):
>>>>> Â Â Âkconfig: add an option to determine a menu's visibility
>>>>
>>>> Hmm, this changeset also went in through the v4l tree?
>>>>
>>> Mauro merely imported the set in his tree to give them visibility and
>>> testing, but they went in trough the kbuild tree after being in -next
>>> for a week.
>>
>> Hmm, git show 86e187ff9bce9fbed7bfed92ae34f491cf1af50f doesn't
>> show a SoB from Michal...
>>
> Why would you expect it to ? Most of the commit in Linus' tree are not
> personally SoB by him.

Sorry, you're right.

>>>> BTW, I got confused:
>>>> Â- make allmodconfig causes e.g.:
>>>> Â Â Â ÂCONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>> Â Â Â ÂCONFIG_VIDEO_TVAUDIO=m
>>>> Â Â=> good
>>>> Â- make oldconfig for my config with almost everything selected,
>>>> except for stuff I know that breaks:
>>>> Â Â Â ÂCONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>> Â Â Â Â# CONFIG_VIDEO_TVAUDIO is not set
>>>> Â Âand no way to manually set CONFIG_VIDEO_TVAUDIO=y?
>>>> Â Â=> bad!
>>> that's difficult to judge without your old configuration.
>>> VIDEO_TVAUDIO is only selected by VIDEO_BT848 which you don't give
>>> information about.
>>
>> I don't have PCI, so I cannot enable VIDEO_BT848.
>>
> so why do you expect VIDEO_TVAUDIO to be enabled ?

I don't expect it to be enabled, I expected to be able to enable it.
Allmodconfig
does enable it.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/