Re: [PATCH] writeback: safety margin for bdi stat errors

[Rik van Riel]

On 12/07/2010 08:11 AM, Wu Fengguang wrote:

> So the root cause is, the bdi_dirty is well under nr_dirty due to
> accounting errors. They should be very close because there is only one
> heavy dirtied bdi in the system. This can be fixed by using
> bdi_stat_sum(), however that's costly on large NUMA machines. So do a
> less costly fix of lowering the bdi limit, so that the accounting
> errors won't lead to the absurd situation "global limit exceeded but
> bdi limit not exceeded".
>
> CC: Rik van Riel<riel@xxxxxxxxxx>
> CC: Peter Zijlstra<a.p.zijlstra@xxxxxxxxx>
> Signed-off-by: Wu Fengguang<fengguang.wu@xxxxxxxxx>

I like this simple approach.

Acked-by: Rik van Riel <riel@xxxxxxxxxx>

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/