Re: [Use cpuops V1 04/11] x86: Use this_cpu_ops for current_cpu_dataaccesses

[Tejun Heo]

On 12/07/2010 04:07 PM, Christoph Lameter wrote:
> On Tue, 7 Dec 2010, Tejun Heo wrote:
> 
>>>> Ooh, was too fast.  I think mixing the use of percpu accesses to
>>>> cpu_info and the wrapper macro current_cpu_data is quite confusing.
>>>> There aren't too many current_cpu_data users in x86 anyway.  Can you
>>>> please make the conversion complete?  I'm moving the above misplaced
>>>> chunk into 03 and not applying 04 for now.
>>>
>>> We cannot make that conversion complete since we cannot obtain the address
>>> if we use a this_cpu operation. Then its better to drop this patch.
>>
>> No, I was talking about dropping current_cpu_data macro.  We can use
>> __this_cpu_ptr() for addresses.  I just find it very confusing to mix
>> current_cpu_data and using direct percpu accessors on cpu_info.
> 
> Hmmm... Ok 21 occurrences. So two patches: Conversion and then
> this_cpu_ops. Or one doing both?

Two steps is better probably.  Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/