Re: [PATCH] MFD: TWL/TPS: fix twl_probe section mismatch warning in mfd/twl-core.c

[Bryan Wu]

On Tue, Dec 7, 2010 at 8:35 AM, Paul Walmsley <paul@xxxxxxxxx> wrote:
>
> Fix the following section mismatch warning when building omap2plus_defconfig:
>
> WARNING: vmlinux.o(.data+0x47d7c): Section mismatch in reference from the variable twl_driver to the function .init.text:twl_probe()
>
> Signed-off-by: Paul Walmsley <paul@xxxxxxxxx>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> ---
>  drivers/mfd/twl-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> index 35275ba..615cf38 100644
> --- a/drivers/mfd/twl-core.c
> +++ b/drivers/mfd/twl-core.c
> @@ -969,7 +969,7 @@ static int twl_remove(struct i2c_client *client)
>  }
>
>  /* NOTE:  this driver only handles a single twl4030/tps659x0 chip */
> -static int __init
> +static int

I think we might change __init to __devinit.

>  twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
>  {
>        int                             status;
> --

Thanks,
-- 
Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/