Re: [PATCH v4 3/7] move memcg reclaimable page into tail of inactive list

[Minchan Kim]

On Mon, Dec 6, 2010 at 12:04 PM, Rik van Riel <riel@xxxxxxxxxx> wrote:
> On 12/05/2010 12:29 PM, Minchan Kim wrote:
>>
>> Golbal page reclaim moves reclaimalbe pages into inactive list
>> to reclaim asap. This patch apply the rule in memcg.
>> It can help to prevent unnecessary working page eviction of memcg.
>
> The patch is right, but the description is wrong.
>
> The rotate_reclaimable_page function moves just written out
> pages, which the VM wanted to reclaim, to the end of the
> inactive list.  That way the VM will find those pages first
> next time it needs to free memory.

Will fix.

>
>> Cc: Balbir Singh<balbir@xxxxxxxxxxxxxxxxxx>
>> Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@xxxxxxxxxxxxxx>
>> Cc: Rik van Riel<riel@xxxxxxxxxx>
>> Cc: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx>
>> Signed-off-by: Minchan Kim<minchan.kim@xxxxxxxxx>
>
> Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>

Thanks, Rik.

>
> --
> All rights reversed
>



-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/