Re: [PATCH] wmi: use memcmp instead of strncmp to compare GUIDs

From: Thadeu Lima de Souza Cascardo
Date: Mon Dec 06 2010 - 17:13:59 EST


On Mon, Dec 06, 2010 at 10:02:31PM +0000, Matthew Garrett wrote:
> Applied to -next, thanks.
>
> --
> Matthew Garrett | mjg59@xxxxxxxxxxxxx

Hello, Matthew.

I consider this one a serious bug and with a trivial fix that should go
to Linus, for the next release candidate. I also consider it should go
to stable releases, and that's why I'm copying stable.

Any out-of-tree wmi driver written for systems with two or more GUIDs
containing any '\0' byte with a common prefix will fail to load because
of this bug. I've hit that, and that's how I found the bug.

Regards,
Cascardo.

Attachment: signature.asc
Description: Digital signature