Re: [PATCH 2/2] tools/virtio: virtio_test tool

From: Thiago Farina
Date: Mon Dec 06 2010 - 11:37:17 EST


On Mon, Nov 29, 2010 at 3:16 PM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
> +#define container_of(ptr, type, member) ({ Â Â Â Â Â Â Â Â Â Â \
> + Â Â Â const typeof( ((type *)0)->member ) *__mptr = (ptr); Â Â\
> + Â Â Â (type *)( (char *)__mptr - offsetof(type,member) );})
> +
> +#define uninitialized_var(x) x = x
> +
> +# ifndef likely
> +# Âdefine likely(x) Â Â(__builtin_expect(!!(x), 1))
> +# endif
> +# ifndef unlikely
> +# Âdefine unlikely(x) Â(__builtin_expect(!!(x), 0))
> +# endif

It seems you are not using these macros. Do you really need them here?
Can't you include the right linux header files for these macros
instead?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/