Re: [PATCH] add additional audit info (read/write length & rngname) for RNG devices

From: Matt Mackall
Date: Mon Dec 06 2010 - 10:32:24 EST


On Mon, 2010-12-06 at 10:21 -0500, Neil Horman wrote:
> Add /dev/[u]random auditing
>
> Patch to enhance auditing of user visible random number generators. Allows us to
> determine how many bytes of random data were obtained on each read from an RNG
> device
>
> Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>
> Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

The random.c parts looks fine to me.

Acked-by: Matt Mackall <mpm@xxxxxxxxxxx>

> + context->aux = (void *)ax;

Redundant cast to void *?

--
Mathematics is the supreme nostalgia of our time.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/