[PATCH -tip v5 0/8] Kprobes/x86: Batch optimization support

From: Masami Hiramatsu
Date: Fri Dec 03 2010 - 04:57:27 EST


Hi,

Here is batch (un)optimizing patch series version 5.
Ingo, I've splitted the biggest patch into 6 patches.

Since current kprobes jump optimization calls stop_machine() for each
probe, it can make a lot of latency noises when (un)registering a lot of
probes (~1000) at once. For example, on 4 core Xeon, 256 probes
optimization takes 770us in average (max 3.3ms).
This patch series introduces batch (un)optimization which modifies
code with just one stop_machine(), and it improves optimization time
to 90us in average (max 330us).

- Introduce text_poke_smp_batch() which modifies multiple
codes with one stop_machine().
- Limit how many probes can be (un)optimized at once.
- Introduce delayed unoptimization for batch processing.

text_poke_smp_batch() will also help Jump label to reduce
its delay coming from text_poke_smp().

Changes in v5:
- Split delayed unregistering patch into 3 cleanup patches
and 3 feature-adding patches.
- Add comments to explain code.
- Fix missing of text_mutex locks.

Changes in v4:
- Update to the latest tip tree.

Changes in v3:
- Set kp.addr = NULL according to Ananth's comment.

Changes in v2:
- Add kprobes selftest bugfix patch.
- Add some comments about locks according to Mathieu's comment.
- Allocate working buffers when initializing kprobes, instead of
using static arraies.
- Merge max optimization limit patch into batch optimizing patch.

Thank you,

---

Masami Hiramatsu (8):
kprobes: Use text_poke_smp_batch for unoptimizing
kprobes: Use text_poke_smp_batch for optimizing
x86: Introduce text_poke_smp_batch() for batch-code modifying
kprobes: Reuse unused kprobe
kprobes: Support delayed unoptimizing
[CLEANUP]kprobes: Separate kprobe optimizing code from optimizer
[CLEANUP]kprobes: Cleanup disabling and unregistering path
[CLEANUP] kprobes: Rename old_p to more appropriate name


arch/x86/include/asm/alternative.h | 7
arch/x86/kernel/alternative.c | 49 +++
arch/x86/kernel/kprobes.c | 113 +++++++
include/linux/kprobes.h | 4
kernel/kprobes.c | 565 ++++++++++++++++++++++++------------
5 files changed, 539 insertions(+), 199 deletions(-)

--
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/