Re: [PATCH] PCI: Disable ASPM if BIOS asks us to

From: Matthew Garrett
Date: Thu Dec 02 2010 - 17:31:47 EST


On Thu, Dec 02, 2010 at 11:24:31PM +0100, Rafael J. Wysocki wrote:
> > + if (!aspm_force) {
> > aspm_disabled = 1;
> > + if (clear)
> > + aspm_clear_state = clear;
>
> Well, is the if(clear) really necessary?

If the FADT disables ASPM, and then we fail to get the control bits,
we'd call this twice and turn off aspm_clear_state.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/