Re: [PATCH] perf: add csv-style output to perf stat

[stephane eranian]

On Wed, Dec 1, 2010 at 6:06 PM, Arnaldo Carvalho de Melo
<acme@xxxxxxxxxxxxxxxxxx> wrote:
> Em Wed, Dec 01, 2010 at 05:00:05PM +0200, Stephane Eranian escreveu:
>> This patch adds an option (-x) to print counts using a CSV-style output.
>> This makes it very easy to import counts directly into your favorite
>> spreadsheet without having to write scripts.
>
> I was about to work on this :-) I think we should use the same option
> 'report' uses:
>
> Â ÂOPT_STRING('t', "field-separator", &symbol_conf.field_sep, "separator",
> Â Â Â Â Â Â Â "separator for columns, no spaces will be added between "
> Â Â Â Â Â Â Â "columns '.' is reserved."),
>
> [root@mica ~]# perf record -F 100000 ls > /dev/null
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.041 MB perf.data (~1798 samples) ]
> [root@mica ~]# perf report --stdio -t, | head -10
> # Events: 1K cycles
> #
> # Overhead,Command,Shared Object,Symbol
> 52.57,  Âls,libc-2.5.so   Â,[.] __GI___strcoll_l
> 3.97,  Âls,ls        ,[.]       24a2
> 3.48,  Âls,libc-2.5.so   Â,[.] __GI_strlen
> 2.33, Â Âls,[ext3] Â Â Â Â Â ,[k] ext3fs_dirhash
> 2.21, Â Âls,[kernel.kallsyms],[k] clear_page_c
> 1.94, Â Âls,[ext3] Â Â Â Â Â ,[k] ext3_htree_store_dirent
> 1.81, Â Âls,[kernel.kallsyms],[k] rt_spin_lock_fastunlock
> [root@mica ~]#
>
> Spaces are being added, gack, will fix. Tried to use the same option letter and
> long option name as in 'sort':
>
> Â Â Â -t, --field-separator=SEP
> Â Â Â Â Â Â Âuse SEP instead of non-blank to blank transition
>
> But then 'perf stat' already uses -t for --tid, so in 'stat' we would have to
> use '-x'/--field-separator.
>
Fine with me.
I can re-spin the patch to add the flexibility to name your SEP.

> Argh, I think we should stop using short options, only assigning something when
> it gets from seldomly used to just before making it the default 8-)

I tend to use the short options....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/