Re: [i915] 2.6.37-rc1 G33 regression : no DVI output

From: Chris Wilson
Date: Tue Nov 23 2010 - 04:08:52 EST


On Sun, 21 Nov 2010 18:36:19 +0100, Vincent Vanackere <vincent.vanackere@xxxxxxxxx> wrote:
> [ 8.740024] [drm:drm_crtc_helper_set_mode], [ENCODER:7:TMDS-7] set [MODE:13:1920x1200]
> [ 8.740027] [drm:intel_sdvo_debug_write], SDVOB: W: 07 01 00 00 00 (SDVO_CMD_SET_IN_OUT_MAP)
> [ 8.747826] [drm:intel_sdvo_write_cmd], command returns response Not supported [2]
> [ 8.747828] [drm:intel_sdvo_debug_write], SDVOB: W: 11 01 00 (SDVO_CMD_SET_TARGET_OUTPUT)
> [ 8.753161] [drm:intel_sdvo_debug_write], SDVOB: W: 11 01 00 (SDVO_CMD_SET_TARGET_OUTPUT)
> [ 8.758485] [drm:intel_sdvo_debug_write], SDVOB: W: 16 28 3C 80 A0 70 B0 23 40 (SDVO_CMD_SET_OUTPUT_TIMINGS_PART1)
> [ 8.771225] [drm:intel_sdvo_write_cmd], command returns response Not supported [2]
> [ 8.771227] [drm:intel_sdvo_debug_write], SDVOB: W: 10 00 (SDVO_CMD_SET_TARGET_INPUT)
> [ 8.775340] [drm:intel_sdvo_debug_write], SDVOB: W: 93 01 00 (SDVO_CMD_SET_HBUF_INDEX)
> [ 8.780688] [drm:intel_sdvo_write_cmd], command returns response Not supported [2]

This was the bug. We aborted the modeset as we tried to perform an
unsupported command. Should be fixed by:

commit da79de97d254145dcb7c08c978b1093eac15ec9c
Author: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Date: Mon Nov 22 11:12:46 2010 +0000

drm/i915/sdvo: Only enable HDMI encodings only if the commandset is supported

As we conflated intel_sdvo->is_hdmi with both having HDMI support on the
ADD along with having HDMI support on the monitor, we would attempt to
use HDMI encodings even if the interface did not support those commands.

Reported-by: Simon Farnsworth <simon.farnsworth@xxxxxxxxxxxx>
Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Tested-by: Simon Farnsworth <simon.farnsworth@xxxxxxxxxxxx>
Reviewed-by: Simon Farnsworth <simon.farnsworth@xxxxxxxxxxxx>

available at
git://git.kernel.org/pub/scm/linux/kernel/git/ickle/drm-intel.git
[drm-intel-fixes]
-Chris

--
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/