Re: [PATCH v2] fs: select: fix information leak to userspace

From: Dan Carpenter
Date: Tue Nov 23 2010 - 00:14:54 EST


On Mon, Nov 22, 2010 at 04:32:34PM -0800, Andrew Morton wrote:
> On Tue, 23 Nov 2010 01:20:48 +0100
> Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
>
> > Le lundi 22 novembre 2010 __ 15:50 -0800, Andrew Morton a __crit :
> >
> > > Well. We certainly assume in many places that
> > >
> > > struct foo {
> > > int a;
> > > int b;
> > > } f = {
> > > .a = 1,
> > > };
> > >
> > > will initialise b to zero. But I doubt if much code at all assumes
> > > that this initialisation patterm will reliably zero out *holes* in the
> > > struct.
> > >
> >
> > We did such assertions in the past, we were wrong.

Well, that sucks... I know I wrote some code that relied on holes
getting zeroed as well. Is there no option to GCC to make this work?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/