Re: [PATCH v3 5/6] KVM: MMU: abstract invalid guest pte mapping

From: Avi Kivity
Date: Mon Nov 22 2010 - 05:17:37 EST


On 11/22/2010 12:18 PM, Xiao Guangrong wrote:
>
> I think the order is reversed. If !is_present_gpte(), it doesn't matter
> if reserved bits are set or not.
>

if !is_present_gpte()&& is_rsvd_bits_set, then we may mark the spte notrap,
so the guest will detect #PF with PFEC.P=PEFC.RSVD=0, but the appropriate PFEC
is PFEC.P=0&& PEFC.RSVD=1 ?

I think the correct PFEC is .P = .RSVD = 0, but best to check on real hardware to be sure.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/