Re: Linux 2.6.37-rc3 (fixmap build error)

From: Linus Torvalds
Date: Sun Nov 21 2010 - 23:33:40 EST


On Sun, Nov 21, 2010 at 6:16 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
>
> I thought that I saw a patch for this one, but I can't find it now.
>
> on i386:
> arch/x86/built-in.o: In function `fix_to_virt':
> /usr/builds/linux-2.6.37-rc3/arch/x86/include/asm/fixmap.h:207: undefined reference to `__this_fixmap_does_not_exist'

Hmm. Does it help to mark __set_fixmap_offset() as "__always_inline"
rather than just "inline"?

Every single "fix_to_virt()" user _should_ use a constant index and
that thing should be inlined and the __this_fixmap_does_not_exist case
should be trivially optimized away.

But if __set_fixmap_offset() doesn't get inlined...

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/