Re: [PATCH] perf: Handle DT_UNKNOWN on filesystems that don'tsupport d_type

[Shawn Bohrer]

On Sun, Nov 21, 2010 at 11:01:53AM +0100, Andreas Schwab wrote:
> Shawn Bohrer <sbohrer@xxxxxxxxxxxxxxx> writes:
> 
> > +		if (((lang_dirent.d_type == DT_DIR &&			\
> > +		      lang_dirent.d_type != DT_UNKNOWN) ||		\
> > +		     (lang_dirent.d_type == DT_UNKNOWN &&		\
> > +		      is_directory(scripts_path, &lang_dirent))) &&	\
> 
> 		if ((lang_dirent.d_type == DT_DIR ||			\
> 		     (lang_dirent.d_type == DT_UNKNOWN &&		\
> 		      is_directory(scripts_path, &lang_dirent))) &&	\
> 
> > +		if ((script_dirent.d_type != DT_DIR &&			\
> > +		     script_dirent.d_type != DT_UNKNOWN) ||		\
> > +		    (script_dirent.d_type == DT_UNKNOWN &&		\
> > +		     !is_directory(lang_path, &script_dirent)))
> 
> 		if (script_dirent.d_type != DT_DIR &&			\
> 		    (script_dirent.d_type != DT_UNKNOWN ||		\
> 		     !is_directory(lang_path, &script_dirent)))
> 
> (DeMorgan: !(a && b) <-> (!a || !b); !(a || b) <-> (!a && !b))

Thanks Andreas, I'll send a follow up patch with the cleanup.

--
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/