Re: [PATCH 2.6.37-rc1] net-next: Add multiqueue support to vmxnet3driver

From: David Miller
Date: Fri Nov 19 2010 - 15:37:18 EST


From: Shreyas Bhatewara <sbhatewara@xxxxxxxxxx>
Date: Fri, 19 Nov 2010 10:46:59 -0800 (PST)

>
> From: Shreyas Bhatewara <sbhatewara@xxxxxxxxxx>
>
> Add multiqueue support to vmxnet3 driver
>
> This change adds multiqueue and thus receive side scaling support
> to vmxnet3 device driver. Number of rx queues is limited to 1 in cases
> where MSI is not configured or one MSIx vector is not available per rx
> queue
>
> Signed-off-by: Shreyas Bhatewara <sbhatewara@xxxxxxxxxx>
> Reviewed-by: Bhavesh Davda <bhavesh@xxxxxxxxxx>

Your patch is corrupted:

> @@ -107,7 +110,7 @@ static void
> vmxnet3_tq_start(struct vmxnet3_tx_queue *tq, struct vmxnet3_adapter *adapter)
> {
> tq->stopped = false;
> - netif_start_queue(adapter->netdev);
> + netif_start_subqueue(adapter->netdev, tq - adapter->tx_queue);
> }
>
>

This hunk has an incorrect header, the hunk header states that
both before and after the change there should be 7 lines in the
code block, but there are 8.

One way this can happen is if you edit the patch in emacs since
it has a patch editing mode which kicks which tries to "fix up"
the hunk headers, but most of the time it actually corrupts them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/