Re: [PATCH 38 of 66] memcontrol: try charging huge pages from stock

[KAMEZAWA Hiroyuki]

On Wed, 03 Nov 2010 16:28:13 +0100
Andrea Arcangeli <aarcange@xxxxxxxxxx> wrote:

> From: Johannes Weiner <hannes@xxxxxxxxxxx>
> 
> The stock unit is just bytes, there is no reason to only take normal
> pages from it.
> 
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>

nonsense. The stock size is CHARGE_SIZE=32*PAGE_SIZE at maximum.
When we make this to be larger than HUGEPAGE size, 2M per cpu at least.
This means memcg's resource "usage" accounting will have 128MB inaccuracy.

Nack.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/