Re: mmotm 2010-11-17-17-03 uploaded

From: Valdis . Kletnieks
Date: Thu Nov 18 2010 - 16:26:18 EST


On Wed, 17 Nov 2010 17:03:30 PST, akpm@xxxxxxxxxxxxxxxxxxxx said:
> The mm-of-the-moment snapshot 2010-11-17-17-03 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/

Using my current .config and a 'make oldconfig' dies a horrid quick death:

CHK include/linux/version.h
CHK include/generated/utsrelease.h
CC arch/x86/kernel/asm-offsets.s
In file included from /usr/src/linux-2.6.37-rc2-mmotm1117/arch/x86/include/asm/suspend_64.h:10:0,
from /usr/src/linux-2.6.37-rc2-mmotm1117/arch/x86/include/asm/suspend.h:4,
from arch/x86/kernel/asm-offsets_64.c:20,
from arch/x86/kernel/asm-offsets.c:4:
/usr/src/linux-2.6.37-rc2-mmotm1117/arch/x86/include/asm/i387.h: In function 'irq_ts_save':
/usr/src/linux-2.6.37-rc2-mmotm1117/arch/x86/include/asm/i387.h:348:2: error: implicit declaration of function 'kernel_locked'
make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1
make: *** [prepare0] Error 2

static inline int irq_ts_save(void)
{
/*
* If in process context and not atomic, we can take a spurious DNA fault.
* Otherwise, doing clts() in process context requires disabling preemption
* or some heavy lifting like kernel_fpu_begin()
*/
if (!in_atomic())
return 0;

in_atomic() did me in. CONFIG_LOCK_KERNEL and CONFIG_BKL are both =y in this build.

Not sure if asm-offsets_64.c needs a #include <smp-locks.h> or if it's something else...

Attachment: pgp00000.pgp
Description: PGP signature