Re: [PATCH][resend][SCSI] Reduce number of sequential pointerderefs in scsi_error.c and reduce size as well

From: Russell King
Date: Thu Nov 18 2010 - 16:07:43 EST


On Thu, Nov 18, 2010 at 09:49:29PM +0100, Jesper Juhl wrote:
> @@ -617,10 +623,10 @@ static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
>
> static int __scsi_try_to_abort_cmd(struct scsi_cmnd *scmd)
> {
> - if (!scmd->device->host->hostt->eh_abort_handler)
> - return FAILED;
> -
> - return scmd->device->host->hostt->eh_abort_handler(scmd);
> + struct scsi_host_template *hostt = scmd->device->host->hostt;
> + if (!hostt->eh_abort_handler)
> + return FAILED;
> + return hostt->eh_abort_handler(scmd);

Not that I have much to do with SCSI anymore... I spotted the above.
Is there any particular reason for using spaces to indent here rather
than our usual tabs?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/