Re: Question about nfs_page_async_flush assertion

[Trond Myklebust]

On Thu, 2010-11-18 at 18:53 +0800, Peng Tao wrote:
> Hi, all,
> 
> nfs_writepages calls into
> write_cache_pages()->nfs_writepages_callback()->nfs_do_writepage()->nfs_page_async_flush(),
> where it asserts BUG_ON(test_bit(PG_CLEAN, &req->wb_flags)).
> My question is: how do we guarantee the request has PG_CLEAN flag set?

We don't. We guarantee that the request has PG_CLEAN cleared, and that
is done when we dirty the page (see nfs_try_to_update_request()).

Cheers
  Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/