Re: [PATCH] hwmon: (lm95241) Rewritten without using macros

[Guenter Roeck]

Hi Davide,

On Wed, Nov 17, 2010 at 06:05:43AM -0500, Davide Rizzo wrote:
> > Removing the above includes violates SubmitChecklist rule #1. Also, please reparent to Linus'
> > latest tree.
> >
> > Other than that, there are a only few formatting issues, but I can take care of those myself.
> > So please re-submit with the above changes, and we should be ready to go.
> >
> > Thanks,
> > Guenter
> 
> Here it is as requested.
> Regards,
> Davide Rizzo
> 
> From: Davide Rizzo <elpa.rizzo@xxxxxxxxx<mailto:elpa.rizzo@xxxxxxxxx>>
> 
> Rewriting of driver/hwmon/lm95241.c to avoid using macros
> 
> Signed-off-by: Davide Rizzo <elpa.rizzo@xxxxxxxxx<mailto:elpa.rizzo@xxxxxxxxx>>
> ---
> --- linux-2.6.37-rc2/drivers/hwmon/lm95241.c    2010-11-16 03:31:02.000000000 +0100
> +++ linux-2.6.37-rc2.elpa/drivers/hwmon/lm95241.c       2010-11-17
> 11:47:21.911752940 +0100

Looks like you still have trouble with line wraps. You might want to get this fixed; 
having to figure out why the patch does not apply is a bit annoying.

> @@ -1,13 +1,9 @@
>  /*
> - * lm95241.c - Part of lm_sensors, Linux kernel modules for hardware
> - *             monitoring
> - * Copyright (C) 2008 Davide Rizzo <elpa-rizzo@xxxxxxxxx>
> + * Copyright (C) 2008, 2010 Davide Rizzo <elpa.rizzo@xxxxxxxxx>
>   *
> - * Based on the max1619 driver. The LM95241 is a sensor chip made by National
> - *   Semiconductors.
> - * It reports up to three temperatures (its own plus up to
> - * two external ones). Complete datasheet can be
> - * obtained from National's website at:
> + * The LM95241 is a sensor chip made by National Semiconductors.
> + * It reports up to three temperatures (its own plus up to two external ones).
> + * Complete datasheet can be obtained from National's website at:
>   *   http://www.national.com/ds.cgi/LM/LM95241.pdf
>   *
>   * This program is free software; you can redistribute it and/or modify
> @@ -27,14 +23,17 @@
> 
>  #include <linux/module.h>
>  #include <linux/init.h>
> -#include <linux/slab.h>
>  #include <linux/jiffies.h>
> +#include <linux/mutex.h>
> +#include <linux/sysfs.h>
> +
> +#include <linux/slab.h>
>  #include <linux/i2c.h>
>  #include <linux/hwmon.h>
>  #include <linux/hwmon-sysfs.h>
>  #include <linux/err.h>
> -#include <linux/mutex.h>
> -#include <linux/sysfs.h>
> +

Moving include statements around is just a whitespace change and should be avoided.
Also, you added a blank line at the end of the file which causes a git whitespace error
when applying the patch.

No need to retransmit. I fixed both and applied the patch with a couple of additional
formatting changes to make the file checkpatch clean.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/