Re: [PATCH] add netdev led trigger

[Pavel Machek]

Hi!

> > > Add a netdev LED trigger for all Blinkenlights lovers...
> > > Originally taken from https://dev.openwrt.org/ticket/2776
> > > Slightly updated for 2.6.24 by Mickey Lauer <mickey@xxxxxxxxxxxx>
> > > and for 2.6.36 by Eric Cooper <ecc@xxxxxxx>
> > 
> > Nice!
> > 
> > > +/*
> > > + * Configurable sysfs attributes:
> > > + *
> > > + * device_name - network device name to monitor
> > > + *
> > > + * interval - duration of LED blink, in milliseconds
> > 
> > This needs to go to Doc/ somewhere.
> 
> Documentation/ABI is the correct place for it.

I was hoping you'd comment on the ABI itself, too. It uses 

echo "foo bar baz" > file

to enable/disable specific events to be "displayed". More traditional
interface would be 

echo disable > file_foo

...
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/